Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using newest Starscream for subscriptions #465

Closed
fassko opened this issue Mar 4, 2019 · 6 comments
Closed

Update using newest Starscream for subscriptions #465

fassko opened this issue Mar 4, 2019 · 6 comments

Comments

@fassko
Copy link
Contributor

fassko commented Mar 4, 2019

I'm using GraphQL subscriptions and noticed that old version of https://github.com/daltoniam/Starscream websockets library is being used. I'm one of the maintainers of that library.

I can update the version where it's needed, but I would need some help with testing it.
Any tips & tricks?

Related to #60

@fassko
Copy link
Contributor Author

fassko commented Mar 4, 2019

It seems that in Cartfile there is newest version, but not in podspec.

@MaxOstPM
Copy link

@fassko Hi! Can you please help me? I don't understand for sure if subscription is working in Apollo Client. Seems that needed method is implemented but nothing happened, also could found any documentation for Apollo Subscriptions!
Waiting for response!
Best regards,
Max!

@fassko
Copy link
Contributor Author

fassko commented Mar 21, 2019

@MaxOstPM

Yeah documentation about subscriptions is missing, I totally agree.

To create a subscription I was using these resources:
hasura/graphql-engine#503
https://stackoverflow.com/questions/51720378/how-to-implement-graphql-subscription-using-apollo-ios-client

I can't share my project because it ties down to closed source project GraphQL scheme.

@fassko
Copy link
Contributor Author

fassko commented Mar 21, 2019

In general everything works (except it doesn't build for other platforms than iOS but for that there is another issue #386 )

With this issue and PR I created I just wanted to update Starscream library which is being used for subscriptions. I'm actually one of maintainers of Starscream library.

@MaxOstPM
Copy link

@fassko I have a problem with a cancelation of subscription. When I want to reopen subscription, after I have canceled it, I'm receiving only errors, and no response

@fassko
Copy link
Contributor Author

fassko commented Mar 26, 2019

@MaxOstPM hard to tell anything without an example. Anyways I think this is out of the scope of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants