Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some initialization of CD variables. #27

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Fix some initialization of CD variables. #27

merged 5 commits into from
Nov 19, 2021

Conversation

dabail10
Copy link
Collaborator

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Fixed some missing initializations.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran a single gx3 debug test with grid_system = 'CD'.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
      This allows the CD debug cases to run. So, will change answers.
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

eclare108213
eclare108213 reviewed Nov 18, 2021
View reviewed changes
cicecore/cicedynB/general/ice_flux.F90 Outdated
uocn (:,:,:) = c0 ! surface ocean currents (m/s)
vocn (:,:,:) = c0
frzmlt(:,:,:) = c0 ! freezing/melting potential (W/m^2)
ss_tltx(:,:,:) = c0 ! sea surface tilt (m/m)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order of these lines is nonintuitive... suggest putting ss_tlt* together, etc

@apcraig apcraig merged commit f91adf0 into cgridDEV Nov 19, 2021
@apcraig apcraig mentioned this pull request Nov 19, 2021
Merged
16 tasks
@apcraig apcraig deleted the dyninit2 branch August 17, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@apcraig apcraig apcraig approved these changes

@daveh150 daveh150 Awaiting requested review from daveh150

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabail10 @eclare108213 @apcraig