Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Fix conv2d transpose for small channel #13341

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

masahi
Copy link
Member

@masahi masahi commented Nov 10, 2022

Fixes the issue reported in https://discuss.tvm.apache.org/t/model-compilation-fails-on-gpu-target/13866

For certain conv2d_transpose workloads, we get funny allocations like

 allocate data_pad[float32 * ((floordiv(((blockIdx.y*2) + 1), 3)*4608) + 576)], storage_scope = shared
 allocate p1.shared[float32 * ((floordiv(((blockIdx.y*2) + 1), 3)*12288) + 1536)], storage_scope = shared

This is apparently due to trying to split a small channel by a large factor.

cc @vinx13

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 10, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: topi See #10317 for details
  • Built docs for commit 9a28460 can be found here.

Generated by tvm-bot

@github-actions github-actions bot requested a review from vinx13 November 10, 2022 00:20
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@masahi masahi merged commit a16a890 into apache:main Nov 10, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 10, 2022
* [TOPI] Fix conv2d transpose for small channel

* black
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* [TOPI] Fix conv2d transpose for small channel

* black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants