Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oauth): adding necessary changes to support bigquery oauth #30674

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

fixing double encoding bug for OAuth JWTs

25cdd3a
Select commit
Loading
Failed to load commit list.
Open

feat(oauth): adding necessary changes to support bigquery oauth #30674

fixing double encoding bug for OAuth JWTs
25cdd3a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 0s

70.82% (+10.33%) compared to 76d897e

View this Pull Request on Codecov

70.82% (+10.33%) compared to 76d897e

Details

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.82%. Comparing base (76d897e) to head (25cdd3a).
Report is 882 commits behind head on master.

Files with missing lines Patch % Lines
superset/db_engine_specs/bigquery.py 50.00% 2 Missing ⚠️
...Modal/DatabaseConnectionForm/OAuth2ClientField.tsx 50.00% 0 Missing and 1 partial ⚠️
superset/commands/database/test_connection.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #30674       +/-   ##
===========================================
+ Coverage   60.48%   70.82%   +10.33%     
===========================================
  Files        1931     1987       +56     
  Lines       76236    80190     +3954     
  Branches     8568     9170      +602     
===========================================
+ Hits        46114    56792    +10678     
+ Misses      28017    21166     -6851     
- Partials     2105     2232      +127

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov