-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dashboard): Retain colors when color scheme not set #30646
base: master
Are you sure you want to change the base?
Conversation
Upvote for this. This problem is annoying. |
f65b57b
to
23dbe5e
Compare
23dbe5e
to
7e23659
Compare
OMG thank you! |
@@ -42,15 +42,29 @@ function openProperties() { | |||
cy.getBySel('header-actions-menu') | |||
.contains('Edit properties') | |||
.click({ force: true }); | |||
cy.wait(500); | |||
cy.get('.ant-modal-body').should('be.visible'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could add a data-test
attribute to select if that's considered more stable than the antD class name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing, LGTM!
I will try to tackle an issue for which after deleting a color scheme from a Dashboard and then editing the Chart from the Dashboard, Explore won't allow to customize the color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This PR does the following:
BEFORE
Color.Consistency.Test.mp4
AFTER
Color.Consistency.Test.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION