Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Module is not defined in Partition chart #30626

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Oct 16, 2024

SUMMARY

#28294 broke the Partition chart dependencies producing a module is not defined error. This PR fixes the dependencies in package-lock.json to restore the plugin.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-10-16 at 09 13 27 Screenshot 2024-10-16 at 09 25 23

TESTING INSTRUCTIONS

Make sure you can create a Partition chart.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sadpandajoe
Copy link
Member

@michael-s-molina do we know why two packages got removed?

@michael-s-molina
Copy link
Member Author

@michael-s-molina do we know why two packages got removed?

If you look at the commits of #28294, you'll see that a new package-lock.json was created removing the packages.

@villebro
Copy link
Member

@michael-s-molina do we know why two packages got removed?

If you look at the commits of #28294, you'll see that a new package-lock.json was created removing the packages.

@michael-s-molina we discussed this with Joe, and the main question was do we understand why the bump removed the critical packages? Is it possible that dependabot is bumping packages with an incorrect command, or something similar? If so, we need to fix that, as this can become very expensive over time if these automated bumps break stuff.

@michael-s-molina
Copy link
Member Author

@villebro It was not a dependabot change. The last two commits were manual.

@villebro
Copy link
Member

It was not a dependabot change. The last two commits were manual.

Oooh, now this makes sense. Thanks for clarifying.

@michael-s-molina michael-s-molina merged commit bad48d0 into apache:master Oct 16, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants