-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql db_engine_spec): adds uniqueidentifier to column_type_mappings #30618
base: master
Are you sure you want to change the base?
fix(mssql db_engine_spec): adds uniqueidentifier to column_type_mappings #30618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement! LGTM, but please add a unit test.
9a71c77
to
5d2afaa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #30618 +/- ##
===========================================
+ Coverage 60.48% 83.90% +23.41%
===========================================
Files 1931 534 -1397
Lines 76236 38636 -37600
Branches 8568 0 -8568
===========================================
- Hits 46114 32418 -13696
+ Misses 28017 6218 -21799
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
Fix for #30612: adds
uniqueidentifier
column_type_mapping
to classMssqlEngineSpec
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Can test using reproduction steps in issue:
ADDITIONAL INFORMATION
uniqueidentifier
causes error in meta database #30612