fix(mssql db_engine_spec): adds uniqueidentifier to column_type_mappings

[rparsonsbb]

SUMMARY

Fix for #30612: adds uniqueidentifier column_type_mapping to class MssqlEngineSpec

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Can test using reproduction steps in issue:

1. Create a few dummy tables in a sql server database:

-- Create the TestUsers table with a uniqueidentifier column
CREATE TABLE Users (
    UserID UNIQUEIDENTIFIER DEFAULT NEWID() NOT NULL,  -- uniqueidentifier column
    FirstName NVARCHAR(50) NOT NULL,
    LastName NVARCHAR(50) NOT NULL,
    Email NVARCHAR(100) NOT NULL
);

-- Create the TestProducts table without a uniqueidentifier column
CREATE TABLE Products (
    ProductID INT IDENTITY(1,1) NOT NULL PRIMARY KEY,  -- Auto-incrementing integer column
    ProductName NVARCHAR(100) NOT NULL,
    Price DECIMAL(10, 2) NOT NULL
);

2. Add data

-- Insert 10 rows of dummy data into the Users table
INSERT INTO TestUsers (FirstName, LastName, Email)
VALUES 
('John', 'Doe', 'john.doe@example.com'),
('Jane', 'Smith', 'jane.smith@example.com'),
('Bob', 'Johnson', 'bob.johnson@example.com'),
('Alice', 'Williams', 'alice.williams@example.com'),
('Tom', 'Brown', 'tom.brown@example.com'),
('Nancy', 'Davis', 'nancy.davis@example.com'),
('Chris', 'Miller', 'chris.miller@example.com'),
('Megan', 'Wilson', 'megan.wilson@example.com'),
('Luke', 'Moore', 'luke.moore@example.com'),
('Emily', 'Taylor', 'emily.taylor@example.com');

-- Insert 10 rows of dummy data into the Products table
INSERT INTO TestProducts (ProductName, Price)
VALUES 
('Laptop', 999.99),
('Smartphone', 699.99),
('Tablet', 299.99),
('Monitor', 199.99),
('Keyboard', 49.99),
('Mouse', 29.99),
('Headphones', 89.99),
('Smartwatch', 199.99),
('Printer', 149.99),
('Camera', 549.99);

3. Create the connection for the database in superset
4. Select from the SQL Lab using the MSSQL connection
5. Select the data using the meta database

ADDITIONAL INFORMATION

• Has associated issue: SQL Server type uniqueidentifier causes error in meta database #30612
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[villebro]

Thanks for the improvement! LGTM, but please add a unit test.

[codecov]

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (76d897e) to head (8748a98).
Report is 864 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/models/sql_types/mssql_sql_types.py	58.33%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30618       +/-   ##
===========================================
+ Coverage   60.48%   83.90%   +23.41%     
===========================================
  Files        1931      534     -1397     
  Lines       76236    38636    -37600     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32418    -13696     
+ Misses      28017     6218    -21799     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.97% <61.53%> (-0.20%)	⬇️
javascript	?
mysql	76.75% <61.53%> (?)
postgres	76.85% <61.53%> (?)
presto	53.44% <61.53%> (-0.36%)	⬇️
python	83.90% <61.53%> (+20.41%)	⬆️
sqlite	76.30% <61.53%> (?)
unit	60.93% <61.53%> (+3.30%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

There's some linting issues, see the CI logs:

I suggest looking into enabling pre-commit hooks, they're very handy for this.