-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Dashboard): Native filters form update endpoint #30609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
api
Related to the REST API
dashboard:native-filters
Related to the native filters of the Dashboard
labels
Oct 15, 2024
/testenv up |
@geido Ephemeral environment spinning up at http://35.87.197.94:8080. Credentials are |
eschutho
approved these changes
Oct 17, 2024
fisjac
approved these changes
Oct 18, 2024
/testenv up |
@geido Ephemeral environment spinning up at http://35.161.33.58:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to the REST API
dashboard:native-filters
Related to the native filters of the Dashboard
doc
Namespace | Anything related to documentation
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR introduces a separate endpoint to store changes to the Native Filters form. Previously, the native filters form would attempt to save the filters even if no changes were made. The form was also sending the whole JSON object containing every individual filter, which caused unnecessary overhead. This PR does the following:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION