Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): Adds a fix for saving time range adhoc_filters #30581

Conversation

ObservabilityTeam
Copy link
Contributor

@ObservabilityTeam ObservabilityTeam commented Oct 11, 2024

…aveModalActions.ts

SUMMARY

The bug occurs when you have a mixed time series chart inside a dashboard and the time range filter from the dashboard does not apply to both queries of the mixed time series chart. If you compare the changes, the previous code would only take care of the adhoc_filters key. The changes make sure that all the adhoc filters keys of the regex /^adhoc_filters/ receive the adhoc time range filter. In case of mixed time series there are two keys namely, adhoc_filters and adhoc_filters_b.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

For manual testing, here is the link of the issue with reproduction steps. You can verify the fix by following them.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup need:more-info Requires more information from author labels Oct 11, 2024
@michael-s-molina
Copy link
Member

@ObservabilityTeam could you fill the PR template with a proper description? Can you also add tests for the fix?

@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 14, 2024
@ObservabilityTeam
Copy link
Contributor Author

@ObservabilityTeam could you fill the PR template with a proper description? Can you also add tests for the fix?

Yes, it will be looked into soon.

@ObservabilityTeam
Copy link
Contributor Author

ObservabilityTeam commented Oct 15, 2024

I have added a test for the fix. The PR description has also been updated. Please let me know if you require anything else, thanks.

@michael-s-molina
Copy link
Member

Thank you for the fix @ObservabilityTeam

@michael-s-molina michael-s-molina merged commit 2c3ba95 into apache:master Oct 15, 2024
34 checks passed
@michael-s-molina michael-s-molina added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 15, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Muhammad Musfir <muhammad.musfir@de-cix.net>
(cherry picked from commit 2c3ba95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need:more-info Requires more information from author size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Range filters from dashboard are not being added to query b for mixed time series
2 participants