-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate HeaderActionsDropdown to typescript #30568
refactor: Migrate HeaderActionsDropdown to typescript #30568
Conversation
1a1f111
to
a60504a
Compare
/testenv up |
@geido Ephemeral environment spinning up at http://54.189.250.97:8080. Credentials are |
|
||
handleMenuClick({ key }) { | ||
handleMenuClick = ({ key }: Record<string, any>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: shouldn't the type here be sth like { key: MenuKeys }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ key: MenuKeys } doesn't work.
I believe the appropriate type is { MenuInfo } from 'rc-menu/lib/interface'; however, rc-menu is not listed in the project's dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your work! Added 1 minor comment
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Migrate HeaderActionsDropdown to typescript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION