refactor: Migrate HeaderActionsDropdown to typescript #30568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnxDev
force-pushed
the
refactor/typescript-migration-HeaderActionsDropdown
branch
from
1a1f111
to
a60504a
Compare
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.189.250.97:8080. Credentials are |
kgabryje
reviewed
Oct 18, 2024
|
|
||
| handleMenuClick({ key }) { | ||
| handleMenuClick = ({ key }: Record<string, any>) => { |
There was a problem hiding this comment.
nit: shouldn't the type here be sth like { key: MenuKeys }?
There was a problem hiding this comment.
{ key: MenuKeys } doesn't work.
I believe the appropriate type is { MenuInfo } from 'rc-menu/lib/interface'; however, rc-menu is not listed in the project's dependencies.
kgabryje
approved these changes
Oct 18, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
Yobi-Aditias
pushed a commit
to sid-indonesia/superset
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate HeaderActionsDropdown to typescript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION