-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard-export): Fixes datasetId is not replaced with datasetUuid in Dashboard export in 4.1.x #30425
Merged
Merged
fix(dashboard-export): Fixes datasetId is not replaced with datasetUuid in Dashboard export in 4.1.x #30425
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a4ba810
Fix replacing datasetId with datasetUuid in Dashboard export
fmannhardt b981c81
Merge branch 'apache:master' into fix-datasetId-datasetuuid
fmannhardt 2d86004
Fix syntax error in test
fmannhardt 086ec00
disable the dashboard test
fmannhardt cedca0b
Merge branch 'gh-origin/master' into fm/fix-datasetId-datasetuuid
fmannhardt f8171fd
Check export_related before going through datasets
fmannhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the risk of introducing yet more regressions, I feel it would be cleaner to do the following:
The point being, no sense in iterating over all datasets, if
export_related
isFalse
, as we're not doing anything else here (look at how charts are exported above).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Since this is now only to invoke the dataset export, it is fine to have the condition before iterating.