Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install/docker): use zstd-baked image for building superset-frontend in containerized env #30279

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Sep 14, 2024

fix(install/docker): use zstd-baked image for building superset-frontend in containerized environment

SUMMARY

Fixes #30206

It turns out that building superset-node in development's Docker Compose file doesn't use image baked with zstd. This PR fixes the issue by using zstd-baked image from existing Dockerfile.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…ontainerized env

Signed-off-by: hainenber <dotronghai96@gmail.com>
@dosubot dosubot bot added the install:docker Installation - docker container label Sep 14, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
@mistercrunch
Copy link
Member

Hey, I have an alternate fix as bycatch as part of #30274. I think it's the proper solution, where docker-compose should be using the superset-node layer which insures more compatibility between the build process when building layers with the docker-compose environment.

It would be great to factor it out of my PR (as opposed to coupling it to the unrelated Slack avatar stuff). Feel free to copy/paste the solution from my PR here and I'll approve and merge.

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title fix(install/docker): install zstd for building superset-frontend in containerized env fix(install/docker): use zstd-baked image for building superset-frontend in containerized env Sep 15, 2024
@hainenber
Copy link
Contributor Author

Hey, I have an alternate fix as bycatch as part of #30274. I think it's the proper solution, where docker-compose should be using the superset-node layer which insures more compatibility between the build process when building layers with the docker-compose environment.

It would be great to factor it out of my PR (as opposed to coupling it to the unrelated Slack avatar stuff). Feel free to copy/paste the solution from my PR here and I'll approve and merge.

Copy-pasted. The issue is still resolved after your alternate fix! :D

@mistercrunch mistercrunch merged commit 2166cbd into apache:master Sep 16, 2024
33 checks passed
@hainenber hainenber deleted the fix-missing-zstd-installation-in-superset-node-dev-image branch September 17, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install:docker Installation - docker container size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zstd not found by superset_node during docker compose up dev mode
2 participants