fix(sqllab): Skip AceEditor in inactive tabs #30171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since
destroyInactiveTabPane
is disabled for improving rendering perf on switching tabs in #26791, I have confirmed that the Ace Editor was monitoring and responding to events even on inactive tabs.As a result, race conditions related to the cursor position were occurring when switching between tabs. This commit addresses these issues by modifying the behavior so that, similar to
destroyInactiveTabPane
, the Ace Editor component is excluded when a tab becomes inactive.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--inactive-ace-editor.mov
Active:
after--inactive-ace-editor.mov
TESTING INSTRUCTIONS
Specs are added
ADDITIONAL INFORMATION