Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Oauth2 in DatabaseSelector #30082

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: Oauth2 in DatabaseSelector #30082

merged 1 commit into from
Sep 4, 2024

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 31, 2024 •
edited
Loading

SUMMARY

This PR modifies onError in the useSchemas and useCatalogs hooks so that the error payload is passed as a parameter. This allow us to prompt the user for OAuth2 when adding datasets or browsing tables in SQL Lab.

Depends on #30071 and #30067.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screenshot 2024-08-31 at 19-21-36 Superset

Screenshot 2024-08-31 at 19-21-30 Superset

Before, generic error messages would flash.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida marked this pull request as ready for review August 31, 2024 23:22
@dosubot dosubot bot added api Related to the REST API authentication Related to authentication labels Aug 31, 2024
@github-actions github-actions bot removed the api Related to the REST API label Aug 31, 2024
@betodealmeida betodealmeida mentioned this pull request Sep 2, 2024
Merged
9 tasks
justinpark
justinpark approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rtexelm
rtexelm approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@rtexelm rtexelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida changed the base branch from create-oauth2-db to master September 3, 2024 23:22
@pull-request-size pull-request-size bot added size/XL and removed size/M labels Sep 3, 2024
@pull-request-size pull-request-size bot added size/M and removed size/XL labels Sep 3, 2024
@betodealmeida betodealmeida merged commit 09dfe2f into master Sep 4, 2024
34 of 35 checks passed
@rusackas rusackas deleted the show-oauth2-errors branch September 27, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

@rtexelm rtexelm rtexelm approved these changes

Assignees
No one assigned
Labels
authentication Related to authentication preset-io size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betodealmeida @justinpark @rtexelm