feat: Oauth2 in DatabaseSelector #30082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR modifies
onError
in theuseSchemas
anduseCatalogs
hooks so that the error payload is passed as a parameter. This allow us to prompt the user for OAuth2 when adding datasets or browsing tables in SQL Lab.Depends on #30071 and #30067.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Before, generic error messages would flash.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION