Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: When hovering Drill By the dashboard is scrolled to the top #30073

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: When hovering Drill By the dashboard is scrolled to the top #30073

merged 1 commit into from
Aug 30, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #30035

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@villebro Ephemeral environment spinning up at http://35.94.21.245:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

villebro
villebro approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed the fix in the eph env

@michael-s-molina michael-s-molina merged commit 548d543 into apache:master Aug 30, 2024
36 of 37 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 3, 2024
@michael-s-molina @sadpandajoe
fix: When hovering Drill By the dashboard is scrolled to the top (#30073
c57f47d 
)

(cherry picked from commit 548d543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe

Assignees
No one assigned
Labels
dashboard:drill-by size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When hovering Drill By the dashboard is scrolled to the top
3 participants
@michael-s-molina @villebro @sadpandajoe