fix(plugins): display correct tooltip (fixes #3342)

[jonaschn]

SUMMARY

Fixes #3342
Display the correct tooltip information for chord charts (source and target values were switched)

BEFORE

AFTER

TESTING INSTRUCTIONS

Example SQL Dataset:

SELECT 'Alice' AS source, 'Bob' AS target, 5 AS interactions UNION ALL
SELECT 'Alice', 'Charlie', 3 UNION ALL
SELECT 'Bob', 'Charlie', 2 UNION ALL
SELECT 'Charlie', 'David', 1  UNION ALL
SELECT 'Bob', 'David', 4

ADDITIONAL INFORMATION

• Has associated issue: Chord popups contain wrong information #3342
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[jonaschn]

The diff looks a bit misleading.
I simply swapped d.source.value and d.target.value (line 133 and 135)

[rusackas]

Agreed that it was wrong and that this fixes the display of the chart, but I'm so confused by the meaning of the diff. I mean, yes - swapping it swaps it, and that works. But now the code (modified by the diff) is
${nodes[d.target.index]} → ${nodes[d.source.index]} which displays the source column then → then the target column. How is this now displaying correctly but with the items named incorrectly? 🤯 Are things mapped incorrectly somewhere further upstream in the code?

In other words, the code being changed here looked right before, and now looks wrong. Something must be mapped incorrectly elsewhere? It's like we mistakenly have + voltage on the black wire and - voltage on the red wire... this PR just swaps the wires at the wrong end, if I'm not mistaken. 😅

NEVERMIND. You're right, that is a confusing diff... I see what you did more clearly now.

LGTM :)

[jonaschn]

@rusackas Thanks for merging. When do you expect to release this change?
Will it be part of 4.1.0?
I would really appreciate it because our users were constantly confused.