Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GAQ): Add Redis Sentinel Support for Global Async Queries #29912

Merged
merged 8 commits into from
Aug 30, 2024

Handle testCase failure with parameterized

4cc558a
Select commit
Loading
Failed to load commit list.
Merged

feat(GAQ): Add Redis Sentinel Support for Global Async Queries #29912

Handle testCase failure with parameterized
4cc558a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 0s

83.64% (+23.15%) compared to 76d897e

View this Pull Request on Codecov

83.64% (+23.15%) compared to 76d897e

Details

Codecov Report

Attention: Patch coverage is 67.94872% with 25 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (76d897e) to head (4cc558a).
Report is 643 commits behind head on master.

Files with missing lines Patch % Lines
superset/async_events/cache_backend.py 59.45% 15 Missing ⚠️
superset/async_events/async_query_manager.py 69.69% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29912       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      529     -1402     
  Lines       76236    38268    -37968     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32009    -14105     
+ Misses      28017     6259    -21758     
+ Partials     2105        0     -2105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.