fix(explore): hide a control wrapped with StashFormDataContainer correctly #28555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With the introduction of StashFormDataContainer to stash form data while hidden, the control row visibility logic has been affected. This is because it currently only checks the direct element properties.
This commit fixes the logic to check with the correct Control component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--invalid-visible-check.mov
After:
after--fix-invalid-visibility.mov
TESTING INSTRUCTIONS
Open a explore to create a table chart
Resize the window over 1200px and then check the control panel
ADDITIONAL INFORMATION