Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(maps): Adding ALL the countries to the Country Map plugin! 🌎 #28265

Merged
merged 16 commits into from
May 15, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 29, 2024

SUMMARY

So... after much ado of getting the Jupyter Notebook up to snuff, this PR adds as many of the countries as I could support. It pulls things from Natural Earth data just... as they are. We might need to adjust some disputed territories, move some islands closer to the mainland, etc., but in broad strokes, this should make us truly global, and we can continue to make overrides to Natural Earth in the notebook as we always have.

This does even more now!

  • Strips out countries that have only one region, and would therefore be useless as a choropleth
  • Standardizes display of maps (now with more colors!)
  • Organizes a bit and cleans out some useless cells
  • Pretties up the country preview grid
  • Simplifies geometry for the country preview grid
  • Skips the first preview_all_countries, since it takes a while and you don't ususally need it
  • Adds a TODO list of countries that could use layout adjustments due to distant islands.
  • Removes the legacy countries_custom folder of geojson files... let's not have that!
  • adds a "speed run" mode that skips rendering charts, and makes it WAAAAAY faster to just update maps locally or as part of CI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added doc Namespace | Anything related to documentation plugins labels Apr 29, 2024
@rusackas rusackas changed the title All the maps Feat(maps): Adding ALL the countries! 🌎 Apr 29, 2024
@rusackas rusackas changed the title Feat(maps): Adding ALL the countries! 🌎 feat(maps): Adding ALL the countries! 🌎 Apr 29, 2024
@rusackas rusackas marked this pull request as ready for review April 30, 2024 03:39
@rusackas rusackas requested a review from villebro as a code owner April 30, 2024 03:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (76d897e) to head (068143f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28265      +/-   ##
==========================================
- Coverage   60.48%   60.48%   -0.01%     
==========================================
  Files        1931     1931              
  Lines       76236    76236              
  Branches     8568     8568              
==========================================
- Hits        46114    46108       -6     
- Misses      28017    28020       +3     
- Partials     2105     2108       +3     
Flag Coverage Δ
javascript 57.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas changed the title feat(maps): Adding ALL the countries! 🌎 feat(maps): Adding 113 countries to the Country Map plugin! 🌎 Apr 30, 2024
@rusackas rusackas changed the title feat(maps): Adding 113 countries to the Country Map plugin! 🌎 feat(maps): Adding 117 countries to the Country Map plugin! 🌎 Apr 30, 2024
@rusackas rusackas changed the title feat(maps): Adding 117 countries to the Country Map plugin! 🌎 feat(maps): Adding ALL the countries to the Country Map plugin! 🌎 Apr 30, 2024
@rusackas
Copy link
Member Author

/testenv up

Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.163.143.161:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@rusackas
Copy link
Member Author

rusackas commented May 1, 2024

Just need a codeowner review from @villebro to get this done :)

@rusackas
Copy link
Member Author

rusackas commented May 8, 2024

/testenv up

Copy link
Contributor

github-actions bot commented May 8, 2024

@rusackas Ephemeral environment spinning up at http://54.185.8.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member Author

rusackas commented May 8, 2024

/testenv up

Copy link
Contributor

github-actions bot commented May 8, 2024

@rusackas Ephemeral environment spinning up at http://54.184.51.66:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazingly valuable work, BIG thanks for all the work here! Validated locally, LGTM!

@rusackas rusackas merged commit cafc1a2 into master May 15, 2024
33 checks passed
@rusackas rusackas deleted the all-the-maps branch May 15, 2024 21:36
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation plugins preset-io size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants