-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maps): Adding ALL the countries to the Country Map plugin! 🌎 #28265
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28265 +/- ##
==========================================
- Coverage 60.48% 60.48% -0.01%
==========================================
Files 1931 1931
Lines 76236 76236
Branches 8568 8568
==========================================
- Hits 46114 46108 -6
- Misses 28017 28020 +3
- Partials 2105 2108 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/testenv up |
@rusackas Ephemeral environment spinning up at http://35.163.143.161:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot!
Just need a codeowner review from @villebro to get this done :) |
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.185.8.117:8080. Credentials are |
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.184.51.66:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazingly valuable work, BIG thanks for all the work here! Validated locally, LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
So... after much ado of getting the Jupyter Notebook up to snuff, this PR adds as many of the countries as I could support. It pulls things from Natural Earth data just... as they are. We might need to adjust some disputed territories, move some islands closer to the mainland, etc., but in broad strokes, this should make us truly global, and we can continue to make overrides to Natural Earth in the notebook as we always have.
This does even more now!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION