Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Slack Avatar integration #27849

Merged
merged 3 commits into from
Apr 16, 2024
Merged

feat: Slack Avatar integration #27849

merged 3 commits into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. feat: Slack Avatar integration

    Our current Avatars are a little dry, using a limited variety of colors
    and showing the user's initials. The app could use a little more
    personality.
    
    Now given we already have a slack integration and administrators can
    configure their `SLACK_API_TOKEN`, I was thinking we can use this
    integration to get Slack's avatars integrated in Superset. Given the
    popularity of Slack and users familiarity with the avatars there,
    I thought it'd be neat to bring a bit more color in Superset.
    
    The approach here is centered around a new endpoint
    `/api/v1/user/{id}/avatar.png`, which fetches from a new column in
    UserAttribute (our one-to-one extension to FAB's User model) for
    avatar_url, and redirects to the destination. When loading for the
    first time, if information is empty and Slack is configured, we ask
    Slack for the URL, which is secret, but serves the image from outside
    the authentication part of their API.
    mistercrunch committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    34b6817 View commit details
    Browse the repository at this point in the history
  2. cleanup

    mistercrunch committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    376ac64 View commit details
    Browse the repository at this point in the history
  3. merge heads

    mistercrunch committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    84cc12f View commit details
    Browse the repository at this point in the history