build(docker): drop build-essential from Docker image

[sebastianliebscher]

SUMMARY

This PR practically drops the apt package build-essential (gcc etc.) from the Docker image, by removing it in the same step it got installed. This package is needed solely to install python-ldap and mysqlclient (from requirements/development.txt).

Important: Users building on top of apache/superset would have to install these tools themselves potentially breaking their Dockerfile depending on their usage.

---

Also removed because not needed:

• rm /var/[log,tmp]/*: Both dirs are empty.
• rm /tmp/*: Basically empty except for a single file from upstream Python Docker image. Removing this file wouldn't save image size.
• apt-get clean: runs automatically for debian-based docker images.

(already merged)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

This results in a smaller image:

• uncompressed: 1.29 GB down to 1.04 GB
• compressed: 382 MB down to 311 MB

TESTING INSTRUCTIONS

• check if the image builds: docker build . -t test
• run docker-compose.yml based on that image and check if all services are running
• successfully run integration tests on that docker stack
• successfully run unit test
• check GitHub CI

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[sfirke]

I follow the idea and it looks nice to reduce the image size and simplify the Dockerfile!

Thanks for flagging the breaking change aspect. Because of that I wonder if this would be a good candidate for a breaking version. Maybe something to discuss on the dev@apache email list? The safest thing would be to insert it into a breaking change window ahead of 4.0.0 but perhaps it's okay to do this before then as it would be a few months out most likely.

[sfirke]

@sebastianliebscher hope you are well! I see this PR just merged and it reminded me of this one. Should this now be closed as already accomplished via the other PR?