fix(Dashboard): Title to rely only on loading prop

apache · Oct 15, 2024 · abfad96 · abfad96
1 parent a0a2131
commit abfad96
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/superset-frontend/src/components/DynamicEditableTitle/index.tsx b/superset-frontend/src/components/DynamicEditableTitle/index.tsx
@@ -99,9 +99,7 @@ export const DynamicEditableTitle = memo(
     });
 
     useEffect(() => {
-      if (title) {
-        setCurrentTitle(title);
-      }
+      setCurrentTitle(title ?? '');
     }, [title]);
 
     useEffect(() => {
@@ -178,7 +176,7 @@ export const DynamicEditableTitle = memo(
       [canEdit],
     );
 
-    if (title === undefined || loading) {
+    if (loading) {
       return (
         <Skeleton.Button
           active