Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-286] Correctly handle poles and anti-meridian in optimized sphere/spheroid distance join #989

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

Kontinuation
Copy link
Member

@Kontinuation Kontinuation commented Aug 28, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

We generate anti-meridian-and-pole-aware envelopes for geometries when performing sphere/spheroid distance join.

If the join predicate ST_DistanceSphere has a custom radius (ST_DistanceSphere(geom1, geom2, radius)), then the join won't be optimized.

How was this patch tested?

  • Added tests for the function for generating anti-meridian-and-pole-aware envelopes.
  • Added SphereDistanceJoinSuite to test sphere/spheroid distance join on geometries scattered on the globe.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@jiayuasu
Copy link
Member

@Kontinuation Please rebase.

@Kontinuation Kontinuation marked this pull request as ready for review August 29, 2023 01:27
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Aug 29, 2023
@jiayuasu jiayuasu merged commit 7ed65fe into apache:master Aug 29, 2023
39 checks passed
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants