Allow spaces in input file paths #9426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjlli
reviewed
Sep 19, 2022
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/org/apache/pinot/common/segment/generation/SegmentGenerationUtils.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9426 +/- ##
============================================
+ Coverage 69.77% 69.83% +0.06%
- Complexity 5092 5097 +5
============================================
Files 1890 1890
Lines 100654 100954 +300
Branches 15327 15348 +21
============================================
+ Hits 70231 70506 +275
- Misses 25445 25466 +21
- Partials 4978 4982 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jackjlli
reviewed
Sep 20, 2022
| } | ||
|
|
||
|
|
||
| public static void main(String[] args) throws Exception { |
There was a problem hiding this comment.
You may not need this code change in your PR.
jackjlli
reviewed
Sep 20, 2022
| @@ -606,4 +607,26 @@ public void close() | |||
| throws IOException { | |||
| super.close(); | |||
| } | |||
|
|
|||
| public static String sanitizeURIString(String uriStr) { | |||
There was a problem hiding this comment.
Same here. You may not need this code change.
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
Co-authored-by: Kartik Khare <kharekartik@Kartiks-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing spaces with
%20in segment utils helps out with this process.Not using URLEncoder here since it also encodes the
/and:charactersdue to which
uri.getSchemereturnsnull