Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging for interrupted exceptions in kinesis #9405

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

KKcorps
Copy link
Contributor

@KKcorps KKcorps commented Sep 15, 2022

Almost all of these logs are due to an Interrupted signal from the main thread because of fetch timeouts. It pollutes the log with irrelevant log messages and hence needs to be removed.

@codecov-commenter
Copy link

Codecov Report

Merging #9405 (6d0b72b) into master (61fc919) will decrease coverage by 43.76%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #9405       +/-   ##
=============================================
- Coverage     69.77%   26.01%   -43.77%     
+ Complexity     5092       44     -5048     
=============================================
  Files          1890     1878       -12     
  Lines        100654   100302      -352     
  Branches      15327    15290       -37     
=============================================
- Hits          70231    26089    -44142     
- Misses        25445    71571    +46126     
+ Partials       4978     2642     -2336     
Flag Coverage Δ
integration1 26.01% <0.00%> (-0.08%) ⬇️
integration2 ?
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/pinot/plugin/stream/kinesis/KinesisConsumer.java 0.00% <0.00%> (-33.34%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/utils/NullValueUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1372 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@navina navina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@apucher apucher merged commit c9587df into apache:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants