Add missing properties in CSV plugin #9399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Sep 14, 2022
| @@ -49,6 +50,12 @@ public class CSVMessageDecoder implements StreamMessageDecoder<byte[]> { | |||
| private static final String CONFIG_CSV_ESCAPE_CHARACTER = "escapeCharacter"; | |||
| private static final String CONFIG_CSV_MULTI_VALUE_DELIMITER = "multiValueDelimiter"; | |||
| public static final String NULL_STRING_VALUE = "nullStringValue"; | |||
| public static final String SKIP_HEADER = "skipHeader"; | |||
| public static final String IGNORE_EMPTY_LINES = "ignoreEmptyLines"; | |||
| public static final String IGNORE_SURROUNDING_SPACE = "ignoreSurroundingSpace"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String IGNORE_SURROUNDING_SPACE = "ignoreSurroundingSpace"; | |
| public static final String IGNORE_SURROUNDING_SPACES = "ignoreSurroundingSpaces"; |
Jackie-Jiang
added
release-notes
|
Can you please update the PR with the new added config keys, and the pinot doc? |
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* Add missing properties in CSV plugin * Fix linting Co-authored-by: Kartik Khare <kharekartik@Kartiks-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following new configurations are being added to csv reader :
skipHeader - Set it to true to skip header line while processing CSV data.
ignoreEmptyLines - Set it to true to ignore empty lines, otherwise send them as empty string and let the processing logic take care of it.
ignoreSurroundingSpaces - Set to true to ignore the spaces around values.
recordSeparator - Character being used to distinguising between multiple lines.
quoteCharacter - single character that is being used for quotes in CSV files
quoteMode -