Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8835] Fix for CSV files with spaces in column names / header #9028

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

ravishankar15
Copy link
Contributor

@ravishankar15 ravishankar15 commented Jul 7, 2022

Fix #8835

Fixing the space issue in the column names, When we have space with quotes we aren't trimming them. I feel that behaviour was intentional by the user.

Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #9028 (a129530) into master (1bcc032) will increase coverage by 6.51%.
The diff coverage is 0.00%.

❗ Current head a129530 differs from pull request most recent head 3333f5e. Consider uploading reports for the commit 3333f5e to get more accurate results

@@             Coverage Diff              @@
##             master    #9028      +/-   ##
============================================
+ Coverage     63.48%   70.00%   +6.51%     
- Complexity     4714     4956     +242     
============================================
  Files          1780     1827      +47     
  Lines         94035    96097    +2062     
  Branches      14128    14360     +232     
============================================
+ Hits          59701    67274    +7573     
+ Misses        30068    24174    -5894     
- Partials       4266     4649     +383     
Flag Coverage Δ
integration1 26.38% <0.00%> (?)
integration2 24.68% <0.00%> (?)
unittests1 66.84% <ø> (+0.01%) ⬆️
unittests2 15.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../pinot/plugin/inputformat/csv/CSVRecordReader.java 0.00% <0.00%> (ø)
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
...ot/plugin/inputformat/json/JSONMessageDecoder.java 0.00% <0.00%> (ø)
...not/plugin/inputformat/csv/CSVRecordExtractor.java 0.00% <0.00%> (ø)
...pinot/server/starter/helix/HelixServerStarter.java 8.33% <0.00%> (ø)
...t/server/api/resources/SegmentMetadataFetcher.java 56.45% <0.00%> (ø)
...pinot/plugin/metrics/yammer/YammerJmxReporter.java 100.00% <0.00%> (ø)
...inot/plugin/inputformat/json/JSONRecordReader.java 0.00% <0.00%> (ø)
...ugin/inputformat/avro/KafkaAvroMessageDecoder.java 0.00% <0.00%> (ø)
...ache/pinot/server/api/resources/DebugResource.java 0.00% <0.00%> (ø)
... and 404 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcc032...3333f5e. Read the comment docs.

@siddharthteotia siddharthteotia changed the title [8835] Fix for CSV files surrounding space [8835] Fix for CSV files with spaces in column names / header Jul 7, 2022
@siddharthteotia siddharthteotia merged commit c1dea59 into apache:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSVRecordReader should trim column names
4 participants