Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined a new broker metric for total query processing time #8941

Merged
merged 3 commits into from
Jun 24, 2022

Conversation

navina
Copy link
Contributor

@navina navina commented Jun 21, 2022

What does this PR do?

Defined a new broker metric for total query processing time and added metric to broker.yaml

Tags to include: observability , release notes

Release Notes:

Includes a new broker timer type metric - queryTotalTimeMs

@navina
Copy link
Contributor Author

navina commented Jun 21, 2022

Review pls : @npawar

@npawar npawar added release-notes Referenced by PRs that need attention when compiling the next release notes observability labels Jun 21, 2022
@kishoreg
Copy link
Member

How is this different from the totaltimems that we have today?

@navina
Copy link
Contributor Author

navina commented Jun 21, 2022

How is this different from the totaltimems that we have today?

Are you referring to BrokerQueryPhase.QUERY_EXECUTION metric? It is currently defined as:

_brokerMetrics.addPhaseTiming(rawTableName, BrokerQueryPhase.QUERY_EXECUTION,
        executionEndTimeNs - routingEndTimeNs);

So, it is not the total query processing time. Total query time should start from the request compilation phase and all the way to the end.

@navina
Copy link
Contributor Author

navina commented Jun 24, 2022

@npawar can you merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
observability release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants