Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when there're two index filter operator h3 inclusion index throw exception #8707

Merged
merged 3 commits into from
May 16, 2022

Conversation

WangCHX
Copy link
Contributor

@WangCHX WangCHX commented May 16, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #8707 (a885d9e) into master (d3c97d5) will decrease coverage by 40.54%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #8707       +/-   ##
=============================================
- Coverage     69.67%   29.13%   -40.55%     
+ Complexity     4571       45     -4526     
=============================================
  Files          1722     1710       -12     
  Lines         89862    89508      -354     
  Branches      13335    13297       -38     
=============================================
- Hits          62610    26075    -36535     
- Misses        22920    61032    +38112     
+ Partials       4332     2401     -1931     
Flag Coverage Δ
integration1 27.00% <ø> (-0.05%) ⬇️
integration2 25.21% <ø> (+0.01%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inot/core/operator/filter/FilterOperatorUtils.java 75.00% <ø> (-11.25%) ⬇️
...in/java/org/apache/pinot/spi/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/spi/config/table/TableType.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c97d5...a885d9e. Read the comment docs.

@Jackie-Jiang Jackie-Jiang changed the title Fix when there're two index filter operator h3 inclusion index throw … Fix when there're two index filter operator h3 inclusion index throw exception May 16, 2022
@Jackie-Jiang Jackie-Jiang merged commit e788a0a into apache:master May 16, 2022
@WangCHX WangCHX deleted the cwang/fff branch May 17, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants