Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pulsar plugin back to distribution #8657

Merged
merged 2 commits into from
May 16, 2022
Merged

Add Pulsar plugin back to distribution #8657

merged 2 commits into from
May 16, 2022

Conversation

KKcorps
Copy link
Contributor

@KKcorps KKcorps commented May 7, 2022

Pulsar plugin was removed from the distribution due to issue #7270

The issue has been fixed for a while now and so this plugin can be added back to the binary dist.

@KKcorps KKcorps added the dependencies Pull requests that update a dependency file label May 7, 2022
walterddr
walterddr approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw you added an unnest field check but then reverted. assuming that's not relevant? please kindly check but otherwise looks good to me.

@KKcorps
Copy link
Contributor Author

KKcorps commented May 16, 2022

That got pulled from a different branch. It was anyways an incorrect fix and not needed.

@KKcorps KKcorps merged commit d3c97d5 into apache:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navina navina navina approved these changes

@walterddr walterddr walterddr approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKcorps @navina @walterddr