Fix the upsert metadata bug when adding segment with same comparison value #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Apr 25, 2022
Jackie-Jiang
force-pushed
the
upsert_tie_fix
branch
from
720db65
to
8c5e48e
Compare
Codecov Report
@@ Coverage Diff @@
## master #8590 +/- ##
============================================
- Coverage 69.02% 63.95% -5.07%
- Complexity 4314 4317 +3
============================================
Files 1691 1646 -45
Lines 88727 86807 -1920
Branches 13466 13255 -211
============================================
- Hits 61244 55519 -5725
- Misses 23197 27267 +4070
+ Partials 4286 4021 -265
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yupeng9
reviewed
Apr 26, 2022
| @@ -103,13 +103,14 @@ public void addSegment(IndexSegment segment, Iterator<RecordInfo> recordInfoIter | |||
| (primaryKey, currentRecordLocation) -> { | |||
| if (currentRecordLocation != null) { | |||
| // Existing primary key | |||
| IndexSegment currentSegment = currentRecordLocation.getSegment(); | |||
| int comparisonResult = recordInfo._comparisonValue.compareTo(currentRecordLocation.getComparisonValue()); | |||
There was a problem hiding this comment.
curious, which particular line caused the bug?
There was a problem hiding this comment.
line 140 in the old code (using == instead of equals() for boxed value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug of reference check instead of value check in
PartitionUpsertMetadataManager.addSegment()