Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixing the bug of missing dot to extract sub props from ingestion job and minion #8511

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

xiangfu0
Copy link
Contributor

fixing the bug of missing dot to extract sub props from ingestion job filesytem spec and minion segmentNameGeneratorSpec

… filesytem spec and minion segmentNameGeneratorSpec
@xiangfu0 xiangfu0 force-pushed the bugfixing_wrong_input_fs_props branch from 4ef1346 to c2ae181 Compare April 12, 2022 00:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #8511 (c2ae181) into master (68c89b7) will increase coverage by 1.35%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #8511      +/-   ##
============================================
+ Coverage     69.26%   70.61%   +1.35%     
+ Complexity     4284     4283       -1     
============================================
  Files          1674     1674              
  Lines         87642    87641       -1     
  Branches      13273    13273              
============================================
+ Hits          60701    61888    +1187     
+ Misses        22676    21450    -1226     
- Partials       4265     4303      +38     
Flag Coverage Δ
integration1 26.92% <0.00%> (?)
integration2 26.03% <0.00%> (+0.17%) ⬆️
unittests1 66.98% <ø> (-0.01%) ⬇️
unittests2 14.10% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/pinot/controller/util/FileIngestionHelper.java 91.02% <ø> (ø)
...nandpush/SegmentGenerationAndPushTaskExecutor.java 0.00% <0.00%> (ø)
...ion/function/DistinctCountAggregationFunction.java 42.60% <0.00%> (-8.97%) ⬇️
...ders/forward/VarByteChunkMVForwardIndexReader.java 93.05% <0.00%> (-2.78%) ⬇️
...tion/groupby/DictionaryBasedGroupKeyGenerator.java 88.25% <0.00%> (-2.76%) ⬇️
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 88.63% <0.00%> (-2.28%) ⬇️
.../aggregation/function/ModeAggregationFunction.java 88.10% <0.00%> (-0.28%) ⬇️
.../helix/core/realtime/SegmentCompletionManager.java 73.02% <0.00%> (+0.20%) ⬆️
...ntroller/helix/core/PinotHelixResourceManager.java 67.66% <0.00%> (+0.25%) ⬆️
...ot/core/query/pruner/ColumnValueSegmentPruner.java 75.13% <0.00%> (+0.52%) ⬆️
... and 114 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c89b7...c2ae181. Read the comment docs.

Copy link
Contributor

@mcvsubbu mcvsubbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the flexibility

@xiangfu0 xiangfu0 merged commit bb46e46 into apache:master Apr 12, 2022
@xiangfu0 xiangfu0 deleted the bugfixing_wrong_input_fs_props branch April 12, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants