Rewrite PinotQuery based on expression hints at instance/segment level #8451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
requested review from
Jackie-Jiang,
mayankshriv,
jackjlli and
richardstartin
xiangfu0
added
the
release-notes
xiangfu0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8451 +/- ##
============================================
- Coverage 70.63% 63.59% -7.05%
+ Complexity 4282 4198 -84
============================================
Files 1663 1652 -11
Lines 87305 86987 -318
Branches 13216 13189 -27
============================================
- Hits 61671 55319 -6352
- Misses 21350 27616 +6266
+ Partials 4284 4052 -232
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
24574f9
to
f37146c
Compare
Jackie-Jiang
reviewed
Apr 1, 2022
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
...t-common/src/main/java/org/apache/pinot/common/request/context/predicate/RangePredicate.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java
Outdated
Show resolved
Hide resolved
pinot-common/src/test/java/org/apache/pinot/common/request/RequestContextUtilsTest.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
expression-hints-server-override
branch
4 times, most recently
from
fefc640
to
7aaa74d
Compare
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
7aaa74d
to
11f01a7
Compare
Jackie-Jiang
approved these changes
Apr 1, 2022
pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/BasePredicate.java
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/Predicate.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
.../org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
11f01a7
to
2a10251
Compare
Jackie-Jiang
approved these changes
Apr 1, 2022
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
2a10251
to
4bfb2df
Compare
jackjlli
approved these changes
Apr 1, 2022
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
4bfb2df
to
292e9de
Compare
xiangfu0
force-pushed
the
expression-hints-server-override
branch
from
292e9de
to
f2637f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite PinotQuery based on expression hints at segment level.
Split the query rewrite logic from Timestamp index: #8343
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Rewrite PinotQuery based on Expression hints at segment level at Pinot Instance query executor.
Documentation