Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Make query console state URL based #8194

Merged
merged 1 commit into from
Feb 11, 2022
Merged

(feat): Make query console state URL based #8194

merged 1 commit into from
Feb 11, 2022

Conversation

shahsank3t
Copy link
Contributor

@shahsank3t shahsank3t commented Feb 11, 2022

Description

This PR fixes #8003

New Tab:
Query - New Tab

Back - Forward Functionality:
Query - Back Forward (3)

@codecov-commenter
Copy link

Codecov Report

Merging #8194 (11f0be6) into master (cf58d37) will decrease coverage by 57.13%.
The diff coverage is n/a.

❗ Current head 11f0be6 differs from pull request most recent head bffc1c0. Consider uploading reports for the commit bffc1c0 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8194       +/-   ##
=============================================
- Coverage     71.34%   14.20%   -57.14%     
+ Complexity     4305       81     -4224     
=============================================
  Files          1623     1578       -45     
  Lines         84365    82484     -1881     
  Branches      12657    12453      -204     
=============================================
- Hits          60186    11717    -48469     
- Misses        20054    69886    +49832     
+ Partials       4125      881     -3244     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.20% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/core/data/table/BaseTable.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1292 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf58d37...bffc1c0. Read the comment docs.

@Jackie-Jiang Jackie-Jiang added the ui UI related issue label Feb 11, 2022
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

@Jackie-Jiang Jackie-Jiang merged commit 6df4b66 into apache:master Feb 11, 2022
@shahsank3t shahsank3t deleted the issue-8003 branch February 11, 2022 19:08
xiangfu0 pushed a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make query console state URL based
3 participants