-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tooltip and modal for table status #7899
add tooltip and modal for table status #7899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7899 +/- ##
============================================
- Coverage 71.31% 68.41% -2.91%
+ Complexity 4087 4034 -53
============================================
Files 1589 1198 -391
Lines 82109 59621 -22488
Branches 12267 9176 -3091
============================================
- Hits 58559 40789 -17770
+ Misses 19584 15954 -3630
+ Partials 3966 2878 -1088
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is super cool! I would suggest always putting the whole
Also, when segment count does not match in EV vs IS, it would be helpful to show the mismatching segments in the tooltip |
This is awesome! @shahsank3t Can you please help review this? The example looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work on this.
+1 Looks good to me!
Description
It's always bothered me how difficult it is to tell why a table with hundreds of segments, even when they're all "good" shows up as "bad". So this adds a tooltip and a modal that explains why.
This is a bit of a big change for what it's doing, so i'm happy for feedback on a better approach.
I need to test this on a bigger cluster internally, but let me know if this is desirable before I do that.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat
, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat
, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notes
and complete the section on Release Notes)Release Notes
Documentation