Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the double unescape of property value #12405

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Jackie-Jiang
Copy link
Contributor

The context is in #12393
The root cause is that we did 2 unescapes when reading the property value (one implicit unescape within the getProperty()).
This PR fixes this behavior so that we can properly read old metadata files. One behavior change when upgrading from Configuration to Configuration2 is that character with surrogates are no longer supported. When surrogates are encountered, treat the value as invalid.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (43dadbf) 61.73% compared to head (fde98c9) 61.74%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ment/creator/impl/SegmentColumnarIndexCreator.java 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12405   +/-   ##
=========================================
  Coverage     61.73%   61.74%           
  Complexity      207      207           
=========================================
  Files          2428     2428           
  Lines        132828   132834    +6     
  Branches      20545    20551    +6     
=========================================
+ Hits          82007    82014    +7     
+ Misses        44811    44803    -8     
- Partials       6010     6017    +7     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.67% <82.60%> (+<0.01%) ⬆️
java-21 61.62% <82.60%> (+<0.01%) ⬆️
skip-bytebuffers-false 61.70% <82.60%> (-0.01%) ⬇️
skip-bytebuffers-true 61.59% <82.60%> (+0.01%) ⬆️
temurin 61.74% <82.60%> (+<0.01%) ⬆️
unittests 61.73% <82.60%> (+<0.01%) ⬆️
unittests1 46.92% <56.52%> (+<0.01%) ⬆️
unittests2 27.72% <26.08%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 0e09e72 into apache:master Feb 13, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_configuration_escape branch February 13, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants