Fix the double unescape of property value #12405
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context is in #12393
The root cause is that we did 2 unescapes when reading the property value (one implicit unescape within the
getProperty()
).This PR fixes this behavior so that we can properly read old metadata files. One behavior change when upgrading from Configuration to Configuration2 is that character with surrogates are no longer supported. When surrogates are encountered, treat the value as invalid.