Fixing the bug for Upsert compaction task generator #12380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snleee
commented
Feb 7, 2024
snleee
commented
- The current task generator had an issue with the null pointer exception when validDocIds metadata doesn't show up on the list of ZK metadata. Fixed the logic to properly handle this case.
- Added the default value for validDocIdsType for API
- Added unit tests
gortiz
approved these changes
Feb 7, 2024
- The current task generator had an issue with the null pointer exception when validDocIds metadata doesn't show up on the list of ZK metadata. Fixed the logic to properly handle this case. - Added the default value for validDocIdsType for API - Added unit tests
snleee
force-pushed
the
improve-upsert-compaction-task-generator
branch
from
c678916
to
4bb1a7f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12380 +/- ##
============================================
- Coverage 61.71% 61.70% -0.02%
Complexity 207 207
============================================
Files 2426 2426
Lines 132776 132784 +8
Branches 20541 20544 +3
============================================
- Hits 81946 81937 -9
- Misses 44817 44832 +15
- Partials 6013 6015 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mayankshriv
approved these changes
Feb 7, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
- The current task generator had an issue with the null pointer exception when validDocIds metadata doesn't show up on the list of ZK metadata. Fixed the logic to properly handle this case. - Added the default value for validDocIdsType for API - Added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.