Add Helper Functions in StarTreeBuilderUtils and StarTreeV2BuilderConfig #12361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added helper function to compare 2 StarTree builder configs. * Added unit test for generateDefaultConfig from JsonNode segment metadata.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12361 +/- ##
============================================
- Coverage 61.72% 61.68% -0.04%
Complexity 207 207
============================================
Files 2426 2426
Lines 132667 132776 +109
Branches 20499 20541 +42
============================================
+ Hits 81888 81906 +18
- Misses 44774 44859 +85
- Partials 6005 6011 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
snleee
approved these changes
Feb 6, 2024
...egment-local/src/main/java/org/apache/pinot/segment/local/startree/StarTreeBuilderUtils.java
Show resolved
Hide resolved
...egment-local/src/main/java/org/apache/pinot/segment/local/startree/StarTreeBuilderUtils.java
Show resolved
Hide resolved
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
…fig (apache#12361) * changed some stuffs * fixed an issue for generating default builder configs * optimize passing segment metadata * Add helper function and unit test * Added helper function to compare 2 StarTree builder configs. * Added unit test for generateDefaultConfig from JsonNode segment metadata. * add additional unit tests. * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following helper functions: