Add CPU metrics for minion purge task #12337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjlli
reviewed
Jan 29, 2024
...uiltin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java
Outdated
Show resolved
Hide resolved
floren06
force-pushed
the
minion-metrics
branch
3 times, most recently
from
f315457
to
7645bf7
Compare
floren06
changed the title
jackjlli
approved these changes
Jan 29, 2024
floren06
force-pushed
the
minion-metrics
branch
from
7645bf7
to
198cafb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12337 +/- ##
============================================
- Coverage 61.65% 61.63% -0.02%
Complexity 1152 1152
============================================
Files 2421 2421
Lines 131872 131879 +7
Branches 20346 20346
============================================
- Hits 81308 81289 -19
- Misses 44600 44627 +27
+ Partials 5964 5963 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
floren06
force-pushed
the
minion-metrics
branch
from
198cafb
to
d94c1a7
Compare
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CPU metrics for minion purge task, i.e. threadCpuTime. Right now there is only task executing time metrics.