-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "rewind()" for CompactedPinotSegmentRecordReader #12329
Conversation
snleee
commented
Jan 27, 2024
- The original implementation for CompactedPinotSegmentRecordReader had an issue with rewind() because we did not re-initialize the validDocId iterator. This PR fixes the issue.
- Added the unit test for checking rewind()
- The original implementation for CompactedPinotSegmentRecordReader had an issue with rewind() because we did not re-initialize the validDocId iterator. This PR fixes the issue. - Added the unit test for checking rewind()
17ad6f8
to
095bc6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12329 +/- ##
============================================
+ Coverage 61.61% 61.66% +0.04%
+ Complexity 1152 1146 -6
============================================
Files 2421 2421
Lines 131839 131842 +3
Branches 20344 20344
============================================
+ Hits 81239 81302 +63
+ Misses 44647 44578 -69
- Partials 5953 5962 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...n/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java
Outdated
Show resolved
Hide resolved
...va/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReaderTest.java
Outdated
Show resolved
Hide resolved
@snleee Should we also fix |
@robertzych Can you elaborate on the false positives? I do have a plan to merge |
@snleee One of the tests in UpsertCompactionMinionClusterIntegrationTest should have been failing without this fix. The changes in the draft PR require this fix. |