Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "rewind()" for CompactedPinotSegmentRecordReader #12329

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

snleee
Copy link
Contributor

@snleee snleee commented Jan 27, 2024

  • The original implementation for CompactedPinotSegmentRecordReader had an issue with rewind() because we did not re-initialize the validDocId iterator. This PR fixes the issue.
  • Added the unit test for checking rewind()

@snleee snleee added the bugfix label Jan 27, 2024
- The original implementation for CompactedPinotSegmentRecordReader
  had an issue with rewind() because we did not re-initialize the
  validDocId iterator. This PR fixes the issue.
- Added the unit test for checking rewind()
@snleee snleee force-pushed the fix-rewind-compacted-segment branch from 17ad6f8 to 095bc6c Compare January 27, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2acf8ea) 61.61% compared to head (5354744) 61.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12329      +/-   ##
============================================
+ Coverage     61.61%   61.66%   +0.04%     
+ Complexity     1152     1146       -6     
============================================
  Files          2421     2421              
  Lines        131839   131842       +3     
  Branches      20344    20344              
============================================
+ Hits          81239    81302      +63     
+ Misses        44647    44578      -69     
- Partials       5953     5962       +9     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.63% <100.00%> (+0.04%) ⬆️
java-21 61.53% <100.00%> (+0.03%) ⬆️
skip-bytebuffers-false 61.65% <100.00%> (+0.04%) ⬆️
skip-bytebuffers-true 61.51% <100.00%> (+0.03%) ⬆️
temurin 61.66% <100.00%> (+0.04%) ⬆️
unittests 61.66% <100.00%> (+0.04%) ⬆️
unittests1 46.78% <0.00%> (+0.02%) ⬆️
unittests2 27.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertzych
Copy link
Contributor

@snleee Should we also fix UpsertCompactionMinionClusterIntegrationTest since it appears to be returning false positives?

@snleee
Copy link
Contributor Author

snleee commented Jan 28, 2024

@robertzych Can you elaborate on the false positives? I do have a plan to merge UpsertCompactionMinionClusterIntegrationTest into UpsertTableIntegrationTest. I will address your comment with that PR. I'm checking this in for now.

@snleee snleee merged commit ed6761a into apache:master Jan 28, 2024
19 checks passed
@snleee snleee deleted the fix-rewind-compacted-segment branch January 28, 2024 05:17
@robertzych
Copy link
Contributor

@snleee One of the tests in UpsertCompactionMinionClusterIntegrationTest should have been failing without this fix. The changes in the draft PR require this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants