Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Array constructor using literal evaluation #12278

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jan 18, 2024

Support Array constructor using literal evaluation.

Before this PR, SELECT ARRAY[1,2] doesn't work, we need to write it as SELECT ARRAY[1,2] FROM existTable, then query is always pushed down to server for processing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 109 lines in your changes are missing coverage. Please review.

Comparison is base (4ad36c3) 61.61% compared to head (ee8bb32) 61.63%.

Files Patch % Lines
...nsform/function/ArrayLiteralTransformFunction.java 0.00% 56 Missing ⚠️
...e/pinot/common/function/scalar/ArrayFunctions.java 25.64% 25 Missing and 4 partials ⚠️
...e/pinot/common/request/context/LiteralContext.java 40.00% 9 Missing ⚠️
...ery/runtime/operator/operands/FunctionOperand.java 60.00% 1 Missing and 3 partials ⚠️
...gment/local/function/InbuiltFunctionEvaluator.java 0.00% 2 Missing and 2 partials ⚠️
...egation/function/HistogramAggregationFunction.java 82.35% 0 Missing and 3 partials ⚠️
...apache/pinot/common/function/FunctionRegistry.java 90.00% 0 Missing and 2 partials ⚠️
...r/transform/function/TransformFunctionFactory.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12278      +/-   ##
============================================
+ Coverage     61.61%   61.63%   +0.01%     
  Complexity     1152     1152              
============================================
  Files          2415     2415              
  Lines        131331   131476     +145     
  Branches      20266    20303      +37     
============================================
+ Hits          80922    81029     +107     
- Misses        44491    44528      +37     
- Partials       5918     5919       +1     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.53% <35.50%> (-0.05%) ⬇️
java-21 61.47% <35.50%> (-0.02%) ⬇️
skip-bytebuffers-false 61.60% <35.50%> (-0.01%) ⬇️
skip-bytebuffers-true 61.44% <35.50%> (+<0.01%) ⬆️
temurin 61.63% <35.50%> (+0.01%) ⬆️
unittests 61.62% <35.50%> (+0.01%) ⬆️
unittests1 46.62% <35.50%> (+0.01%) ⬆️
unittests2 27.82% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangfu0 xiangfu0 force-pushed the array-gen-literal-eval branch 2 times, most recently from ee279e1 to 94b7645 Compare January 18, 2024 05:09
@walterddr walterddr merged commit 6bb387a into apache:master Jan 18, 2024
19 checks passed
@Jackie-Jiang Jackie-Jiang added feature documentation release-notes Referenced by PRs that need attention when compiling the next release notes labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation feature release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants