Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that would take validdocids snapshots redundantly #12246

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Jan 9, 2024

fix a bug from #12232, that would take redundant snapshots for segments w/o existing snapshot. added tests to assert the order of taking snapshots

@klsince klsince added the bugfix label Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9947bc5) 61.53% compared to head (5be9d03) 61.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12246      +/-   ##
============================================
- Coverage     61.53%   61.40%   -0.13%     
  Complexity     1153     1153              
============================================
  Files          2416     2416              
  Lines        131196   131199       +3     
  Branches      20248    20249       +1     
============================================
- Hits          80726    80565     -161     
- Misses        44570    44729     +159     
- Partials       5900     5905       +5     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 <0.01% <0.00%> (-61.48%) ⬇️
java-21 61.40% <100.00%> (-0.01%) ⬇️
skip-bytebuffers-false 27.72% <100.00%> (-33.79%) ⬇️
skip-bytebuffers-true 61.40% <100.00%> (+0.02%) ⬆️
temurin 61.40% <100.00%> (-0.13%) ⬇️
unittests 61.40% <100.00%> (-0.13%) ⬇️
unittests1 46.41% <0.00%> (-0.22%) ⬇️
unittests2 27.73% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klsince klsince merged commit 8c86ad4 into apache:master Jan 9, 2024
19 checks passed
@klsince klsince deleted the bugfix_validdocids_snapshot branch January 9, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants