Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11761 - fix for connection pool error #12221

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

abhijeetkushe
Copy link
Contributor

@abhijeetkushe abhijeetkushe commented Jan 4, 2024

This PR includes a fix for #11761 . This is based on https://github.com/apache/pinot/pull/12063/files fix proposed by @klsince

  • I have tested that connection pool is fixed for KinesisConsumer and the S3 files are also flushed periodically for Realtime table

These labels need to be added

  • bugfix
  • testing incase additional testing is needed for other users who faced this issue

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8f5fa80) 61.50% compared to head (b30932d) 61.53%.

Files Patch % Lines
.../org/apache/pinot/plugin/filesystem/S3PinotFS.java 0.00% 1 Missing ⚠️
...lugin/stream/kinesis/KinesisConnectionHandler.java 0.00% 1 Missing ⚠️
...gin/stream/kinesis/server/KinesisDataProducer.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12221      +/-   ##
============================================
+ Coverage     61.50%   61.53%   +0.02%     
- Complexity      207     1152     +945     
============================================
  Files          2416     2416              
  Lines        131179   131179              
  Branches      20246    20246              
============================================
+ Hits          80686    80723      +37     
+ Misses        44595    44558      -37     
  Partials       5898     5898              
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.50% <0.00%> (+0.03%) ⬆️
java-21 61.41% <0.00%> (+0.02%) ⬆️
skip-bytebuffers-false 61.52% <0.00%> (+0.02%) ⬆️
skip-bytebuffers-true 61.37% <0.00%> (+<0.01%) ⬆️
temurin 61.53% <0.00%> (+0.02%) ⬆️
unittests 61.53% <0.00%> (+0.02%) ⬆️
unittests1 46.62% <ø> (+0.02%) ⬆️
unittests2 27.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@klsince klsince merged commit 298e8d9 into apache:master Jan 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants