Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage][hotfix] table name not escaped during route finding dummy query #12212

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Jan 2, 2024

table name is not escaped during routing entry discovery.
this adds double quote around the table name for dummy query

@walterddr walterddr added bugfix multi-stage Related to the multi-stage query engine labels Jan 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b4e19a) 61.51% compared to head (b5d54d9) 61.52%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #12212   +/-   ##
=========================================
  Coverage     61.51%   61.52%           
+ Complexity     1153     1146    -7     
=========================================
  Files          2415     2415           
  Lines        131157   131157           
  Branches      20245    20245           
=========================================
+ Hits          80683    80693   +10     
+ Misses        44575    44567    -8     
+ Partials       5899     5897    -2     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.47% <100.00%> (+26.70%) ⬆️
java-21 61.38% <100.00%> (-0.02%) ⬇️
skip-bytebuffers-false 61.47% <100.00%> (-0.03%) ⬇️
skip-bytebuffers-true 61.38% <100.00%> (+<0.01%) ⬆️
temurin 61.52% <100.00%> (+<0.01%) ⬆️
unittests 61.51% <100.00%> (+<0.01%) ⬆️
unittests1 46.61% <100.00%> (+0.01%) ⬆️
unittests2 27.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description.

@walterddr walterddr merged commit add2236 into apache:master Jan 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants