Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine warning msg when preloading segments not exist on server #12153

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Dec 14, 2023

When segment does not exist on the server before, the method to get validDocId snapshot file path throws exception. The current error log msg is too verbose. As the segment can be skipped upon this error, so changed to a concise warning log for this case.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f22de0a) 61.65% compared to head (fd94a82) 61.63%.

Files Patch % Lines
...t/local/upsert/BaseTableUpsertMetadataManager.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12153      +/-   ##
============================================
- Coverage     61.65%   61.63%   -0.02%     
  Complexity     1152     1152              
============================================
  Files          2407     2407              
  Lines        130927   130930       +3     
  Branches      20224    20224              
============================================
- Hits          80718    80705      -13     
- Misses        44326    44336      +10     
- Partials       5883     5889       +6     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.59% <75.00%> (+<0.01%) ⬆️
java-21 61.49% <75.00%> (-0.04%) ⬇️
skip-bytebuffers-false 61.62% <75.00%> (-0.02%) ⬇️
skip-bytebuffers-true 61.47% <75.00%> (+<0.01%) ⬆️
temurin 61.63% <75.00%> (-0.02%) ⬇️
unittests 61.63% <75.00%> (-0.02%) ⬇️
unittests1 46.66% <0.00%> (-0.03%) ⬇️
unittests2 27.70% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 46ae9e9 into apache:master Dec 15, 2023
19 checks passed
@klsince klsince deleted the refine_warn_msg branch January 18, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants