Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add singleton registry for all metrics #12119

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

We already have singleton registry for broker and server metrics, this PR adds the registry for controller and minion

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f5f878e) 61.61% compared to head (917166b) 27.63%.
Report is 1 commits behind head on master.

Files Patch % Lines
...apache/pinot/common/metrics/ControllerMetrics.java 0.00% 3 Missing ⚠️
...org/apache/pinot/common/metrics/MinionMetrics.java 0.00% 3 Missing ⚠️
...ava/org/apache/pinot/minion/BaseMinionStarter.java 0.00% 1 Missing ⚠️
.../pinot/minion/taskfactory/TaskFactoryRegistry.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12119       +/-   ##
=============================================
- Coverage     61.61%   27.63%   -33.99%     
+ Complexity     1152      207      -945     
=============================================
  Files          2406     2406               
  Lines        130851   130859        +8     
  Branches      20218    20218               
=============================================
- Hits          80621    36160    -44461     
- Misses        44347    91963    +47616     
+ Partials       5883     2736     -3147     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 ?
java-11 27.63% <20.00%> (-33.92%) ⬇️
java-21 <0.01% <0.00%> (-61.50%) ⬇️
skip-bytebuffers-false 27.63% <20.00%> (-33.96%) ⬇️
skip-bytebuffers-true ?
temurin 27.63% <20.00%> (-33.99%) ⬇️
unittests 27.62% <20.00%> (-33.98%) ⬇️
unittests1 ?
unittests2 27.62% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit 56ecafc into apache:master Dec 8, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the make_metrics_singleton branch December 12, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants