-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling SegmentGenerationAndPushTask to push segment to realtime table #12084
Conversation
@snleee - Please review. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12084 +/- ##
============================================
- Coverage 61.62% 61.62% -0.01%
+ Complexity 1152 1147 -5
============================================
Files 2389 2389
Lines 129824 129823 -1
Branches 20083 20082 -1
============================================
- Hits 80009 80008 -1
+ Misses 43989 43987 -2
- Partials 5826 5828 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
235fc35
to
6012ddd
Compare
6012ddd
to
3865162
Compare
3865162
to
49a931a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
Outdated
Show resolved
Hide resolved
...inot/plugin/minion/tasks/segmentgenerationandpush/SegmentGenerationAndPushTaskGenerator.java
Outdated
Show resolved
Hide resolved
ef78733
to
4c2b21c
Compare
eec9266
to
b68c506
Compare
Description:
Following are the changes . Segment upload to realtime was already in this PR
pushSegments
sendSegmentUris
sendSegmentUriAndMetadata
Testing:
Integration tests for SegmentGenerationAndPushTask that validates ingestion into realtime table.