Fix the misuse of star-tree when all predicates are always false under OR #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12003 +/- ##
============================================
- Coverage 61.65% 61.62% -0.04%
Complexity 1150 1150
============================================
Files 2385 2385
Lines 129250 129251 +1
Branches 20007 20009 +2
============================================
- Hits 79690 79645 -45
- Misses 43748 43809 +61
+ Partials 5812 5797 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jackie-Jiang
force-pushed
the
fix_star_tree_predicate_is_false
branch
from
f12cefd
to
3a37769
Compare
walterddr
reviewed
Nov 15, 2023
| @@ -78,7 +78,8 @@ private GroupByOperator buildNonFilteredGroupByPlan() { | |||
|
|
|||
| // Use star-tree to solve the query if possible | |||
| List<StarTreeV2> starTrees = _indexSegment.getStarTrees(); | |||
| if (starTrees != null && !_queryContext.isSkipStarTree()) { | |||
| if (!_queryContext.isNullHandlingEnabled() && !filterOperator.isResultEmpty() && starTrees != null | |||
There was a problem hiding this comment.
so we were missing null handling enable flag before as well here? :-P
There was a problem hiding this comment.
Unfortunately yes..
walterddr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11718
Fixes 2 scenarios where star-tree shouldn't be used: