Adding byte functions for UUIDs #11988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11988 +/- ##
=============================================
- Coverage 61.61% 34.89% -26.73%
- Complexity 207 927 +720
=============================================
Files 2385 2309 -76
Lines 129214 125477 -3737
Branches 20003 19445 -558
=============================================
- Hits 79613 43779 -35834
- Misses 43801 78584 +34783
+ Partials 5800 3114 -2686
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 843 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Jackie-Jiang
approved these changes
Nov 14, 2023
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use UUIDs as identifiers in our data that we ingest into Pinot and we noticed that these take up quite a lot of space because they can't easily be compressed in their String representation. Converting them to bytes, however, results in about 30% storage savings.
This adds two new scalar functions for dealing with UUIDs:
toUUIDBytes: turns a String representation of a UUID to bytesfromUUIDBytes: turns a byte representation of a UUID back to a StringThanks for the help of @kishoreg for investigating this