Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 11974... exclude module-info.class during shade operations #11975

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

timveil
Copy link
Collaborator

@timveil timveil commented Nov 8, 2023

the existence of module-info.class in shaded jars causes maven to log numerous warnings like [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.. This pull request updates the base maven-shade-plugin configuration to exclude these files. This PR fixes #11974.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.41%. Comparing base (972b555) to head (5f3962b).
Report is 1201 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11975      +/-   ##
============================================
- Coverage     61.44%   61.41%   -0.04%     
  Complexity     1141     1141              
============================================
  Files          2385     2385              
  Lines        129189   129189              
  Branches      19998    19998              
============================================
- Hits          79381    79336      -45     
- Misses        44061    44103      +42     
- Partials       5747     5750       +3     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.37% <ø> (-0.03%) ⬇️
java-21 61.28% <ø> (-0.03%) ⬇️
skip-bytebuffers-false 61.39% <ø> (-0.04%) ⬇️
skip-bytebuffers-true 34.68% <ø> (-26.59%) ⬇️
temurin 61.41% <ø> (-0.04%) ⬇️
unittests 61.40% <ø> (-0.04%) ⬇️
unittests1 46.66% <ø> (-0.04%) ⬇️
unittests2 27.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang merged commit a986dd1 into apache:master Nov 9, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve maven [WARNING] Discovered module-info.class. Shading will break its strong encapsulation.
3 participants